[ZCash] Implement Zcash sync process and Orchard inputs spending #27018
+3,041
−750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
cypt4
changed the title
Comment on lines
+71
to
+80
| // Create shielded transaction | ||
| zcash_wallet_service_->CreateShieldedTransaction( | ||
| chain_id, from->Clone(), zec_tx_data->to, zec_tx_data->amount, memo, | ||
| base::BindOnce(&ZCashTxManager::ContinueAddUnapprovedTransaction, | ||
| weak_factory_.GetWeakPtr(), chain_id, from.Clone(), | ||
| origin, std::move(callback))); | ||
| } else { | ||
| // Create transparent to shielded transaction | ||
| zcash_wallet_service_->CreateShieldTransaction( | ||
| chain_id, from->Clone(), zec_tx_data->to, zec_tx_data->amount, memo, |
There was a problem hiding this comment.
Can it have some better naming?
CreateShieldedTransaction
CreateShieldTransaction
|
|
||
| // ZCashScanBlocksTask scans blocks from the last scanned block to the provided | ||
| // right border. Splits this range to subranges and uses a bunch of smaller | ||
| // tasks to process. Current implementation uses sequentally scanning. Parallel |
| @@ -259,6 +259,23 @@ const GURL MakeGetCompactBlocksURL(const GURL& base_url) { | |||
| return base_url.ReplaceComponents(replacements); | |||
| } | |||
|
|
|||
| const GURL MakeGetSubtreeRootsURL(const GURL& base_url) { | |||
There was a problem hiding this comment.
We should not return values marked with const. This applies to other functions in this file
const GURL
Comment on lines
+158
to
+159
| // DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); | ||
| // return storage_.UpdateSubtreeRoots(account_id, start_index, roots); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#42898
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: